Disable test large_file on 32-bit rr. #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because 32-bit rr is compiled without `-D_FILE_OFFSET_BITS=64`. Therefore the open of the large file fails with EOVERFLOW. [FATAL src/record_syscall.cc:5531:process_execve() errno: EOVERFLOW] (task 2019470 (rec:2019470) at time 14) -> Assertion `fd.is_open()' failed to hold.
|
I would probably take a fix for this, but this is fine too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because 32-bit rr is compiled without
-D_FILE_OFFSET_BITS=64. Therefore the open of the large file fails with EOVERFLOW.[FATAL src/record_syscall.cc:5531:process_execve() errno: EOVERFLOW]
(task 2019470 (rec:2019470) at time 14)
-> Assertion `fd.is_open()' failed to hold.
My attempts to either use
-D_FILE_OFFSET_BITS=64or open64/stat64 were leading to a row of changes involving size_t/off_t or struct stat, which I guess are not desired for the fading 32-bit architecture?